ulysses-you commented on PR #2687:
URL:
https://github.com/apache/incubator-kyuubi/pull/2687#issuecomment-1130947025
For now, the timeout of `ENGINE_INIT_TIMEOUT` only considers the elapsed
time of creating engine. That said, it does not consider the time of acquiring
lock. I'm not sure if we should include the time when we are acquiring the
lock. And if we want that, we should do some changes.
The current code path:
```scala
tryWithLock(discoveryClient) {
val startTime ..
if (started + timeout <= System.currentTimeMillis()) {
throw ..
}
}
```
The expected code path:
```scala
val startTime ..
tryWithLockAndThrowWhenTimeout(startTime, discoveryClient) {
if (started + timeout <= System.currentTimeMillis()) {
throw ..
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
