ulysses-you commented on code in PR #2687:
URL: https://github.com/apache/incubator-kyuubi/pull/2687#discussion_r876580513


##########
kyuubi-server/src/test/scala/org/apache/kyuubi/engine/EngineRefSuite.scala:
##########
@@ -205,6 +208,8 @@ class EngineRefSuite extends KyuubiFunSuite {
     conf.set(ENGINE_POOL_SIZE, 3)
     val engine6 = new EngineRef(conf, user, id, null)
     assert(engine6.subdomain.startsWith(s"$enginePoolName-"))
+    conf.unset(ENGINE_POOL_NAME)
+    conf.unset(ENGINE_POOL_SIZE)

Review Comment:
   yeah, let me remove this first to see any issue in test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to