SteNicholas commented on code in PR #2678:
URL: https://github.com/apache/incubator-kyuubi/pull/2678#discussion_r878966253
##########
externals/kyuubi-trino-engine/src/test/scala/org/apache/kyuubi/engine/trino/TrinoStatementSuite.scala:
##########
@@ -52,16 +52,16 @@ class TrinoStatementSuite extends WithTrinoContainerServer {
assert(this.schema === trinoStatement.getCurrentDatabase)
val trinoStatement2 = TrinoStatement(trinoContext, kyuubiConf, "use sf1")
- trinoStatement2.execute()
-
+ // if trinoStatement.execute return iterator is lazy, call toArray to
strict evaluation
Review Comment:
How does the end user knows whether `trinoStatement.execute` is lazy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
