cxzl25 commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r894629477
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -75,6 +64,13 @@ class SparkTBinaryFrontendService(
val respConfiguration = new java.util.HashMap[String, String]()
respConfiguration.put("kyuubi.engine.id", sc.applicationId)
+ if (req.getConfiguration != null) {
Review Comment:
Yes, maybe we can delay the execution of the initialization sql.
Another advantage of doing this is that, in the long-running Spark on YARN,
the token applied for by the app expires, but the driver (AM) fails and starts
to retry, the initialization SQL will fail, and the engine will exit.
If the execution is delayed, the driver still has a chance to update the
token.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
