wForget commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r895281014
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -106,7 +108,9 @@ class KyuubiSessionImpl(
Option(password).filter(_.nonEmpty).getOrElse("anonymous")
}
try {
- _client = KyuubiSyncThriftClient.createClient(user, passwd, host,
port, sessionConf)
+ val engineSessionConf = sessionConf.clone
+
engineSessionConf.set(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY,
engineCredentials)
Review Comment:
Sorry, I didn't express my idea exactly. I mean that we need to pass this
configuration through the 'openSession' method instead of the 'createClient'`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
