turboFei commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r896440548
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -98,6 +98,19 @@ class KyuubiSessionImpl(
private[kyuubi] def openEngineSession(extraEngineLog: Option[OperationLog] =
None): Unit = {
withDiscoveryClient(sessionConf) { discoveryClient =>
+ val engineCredentials = renewEngineCredentials()
+ var openEngineSessionConf = optimizedConf
+ if (engineCredentials.nonEmpty) {
+ sessionConf.set(KYUUBI_ENGINE_CREDENTIALS_KEY, engineCredentials)
+ openEngineSessionConf =
+ optimizedConf ++ Map(KYUUBI_ENGINE_CREDENTIALS_KEY ->
engineCredentials)
+ }
+
+ engine = new EngineRef(
+ sessionConf,
Review Comment:
how about this?
@ulysses-you
we need transfer the config item to EngineRef
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
