ulysses-you commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r896412872
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -107,7 +111,11 @@ class KyuubiSessionImpl(
}
try {
_client = KyuubiSyncThriftClient.createClient(user, passwd, host,
port, sessionConf)
- _engineSessionHandle = _client.openSession(protocol, user, passwd,
optimizedConf)
+ _engineSessionHandle = _client.openSession(
+ protocol,
+ user,
+ passwd,
+ optimizedConf ++ Map(KYUUBI_ENGINE_CREDENTIALS_KEY ->
engineCredentials))
Review Comment:
I think a more safer way is that check `engineCredentials` is vaildated
before inject into engine, so if engine get the KYUUBI_ENGINE_CREDENTIALS_KEY
that means it must has credentials.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
