ulysses-you commented on code in PR #3063:
URL: https://github.com/apache/incubator-kyuubi/pull/3063#discussion_r920643838
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/JpsApplicationOperation.scala:
##########
@@ -65,6 +65,9 @@ class JpsApplicationOperation extends ApplicationOperation {
val (id, _) = idAndCmd.splitAt(idAndCmd.indexOf(" "))
try {
s"kill -15 $id".lineStream
+ if (getEngine(tag).nonEmpty) {
+ killApplicationByTag(tag)
Review Comment:
if so the first kill will fail since there is no that process, shall we
check the result of the command ? if the process is not found we should try to
kill again, otherwise do nothing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
