turboFei commented on code in PR #3063:
URL: https://github.com/apache/incubator-kyuubi/pull/3063#discussion_r920702868
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/JpsApplicationOperation.scala:
##########
@@ -68,7 +68,11 @@ class JpsApplicationOperation extends ApplicationOperation {
(true, s"Succeeded to terminate: $idAndCmd")
} catch {
case e: Exception =>
- (false, s"Failed to terminate: $idAndCmd, due to ${e.getMessage}")
+ if (getEngine(tag).nonEmpty) {
+ killApplicationByTag(tag)
+ } else {
+ (false, s"Failed to terminate: $idAndCmd, due to ${e.getMessage}")
+ }
Review Comment:
the spark-submit may generate two process.
And we might fail to kill the running batch jobs after each test in
BatchResourceSuite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
