turboFei commented on code in PR #3063:
URL: https://github.com/apache/incubator-kyuubi/pull/3063#discussion_r920705561
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/KyuubiOperation.scala:
##########
@@ -156,8 +157,11 @@ abstract class KyuubiOperation(session: Session) extends
AbstractOperation(sessi
override def shouldRunAsync: Boolean = false
override def setState(newState: OperationState): Unit = {
+ MetricsSystem.tracing { ms =>
+ ms.decCount(MetricRegistry.name(OPERATION_STATE, opType,
state.toString.toLowerCase))
+ ms.incCount(MetricRegistry.name(OPERATION_STATE, opType,
newState.toString.toLowerCase))
+ ms.markMeter(MetricRegistry.name(OPERATION_STATE,
newState.toString.toLowerCase))
Review Comment:
I think we can remove this one, it seems meaning less and always increasing.
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/KyuubiOperation.scala:
##########
@@ -156,8 +157,11 @@ abstract class KyuubiOperation(session: Session) extends
AbstractOperation(sessi
override def shouldRunAsync: Boolean = false
override def setState(newState: OperationState): Unit = {
+ MetricsSystem.tracing { ms =>
+ ms.decCount(MetricRegistry.name(OPERATION_STATE, opType,
state.toString.toLowerCase))
+ ms.incCount(MetricRegistry.name(OPERATION_STATE, opType,
newState.toString.toLowerCase))
+ ms.markMeter(MetricRegistry.name(OPERATION_STATE,
newState.toString.toLowerCase))
Review Comment:
I think we can remove this one, it seems meaning-less and always increasing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
