yaooqinn commented on code in PR #3425:
URL: https://github.com/apache/incubator-kyuubi/pull/3425#discussion_r966847073
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/PrivilegesBuilder.scala:
##########
@@ -411,6 +469,26 @@ object PrivilegesBuilder {
outputObjs += tablePrivileges(table, actionType = actionType)
buildQuery(getQuery, inputObjs)
+ case "AppendData" => // DsV2 insert
+ val table = getPlanField[AnyRef]("table")
+ val tableIdent = getFieldVal[Option[Identifier]](table, "identifier")
+ outputObjs += tablePrivilegesWithIdentifier(tableIdent.get, actionType
= INSERT)
+ buildQuery(getQuery, inputObjs)
+
+ case "UpdateTable" => // DsV2 update
+ val table = getPlanField[AnyRef]("table")
+ val tableIdent = getFieldVal[Option[Identifier]](table, "identifier")
+ outputObjs += tablePrivilegesWithIdentifier(tableIdent.get, actionType
= UPDATE)
+ // todo INSERT ?
Review Comment:
if you add TODO, better to create an issue to track. otherwise, todo is
never to be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
