bowenliang123 commented on code in PR #3425:
URL: https://github.com/apache/incubator-kyuubi/pull/3425#discussion_r966855967
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/PrivilegesBuilder.scala:
##########
@@ -411,6 +469,26 @@ object PrivilegesBuilder {
outputObjs += tablePrivileges(table, actionType = actionType)
buildQuery(getQuery, inputObjs)
+ case "AppendData" => // DsV2 insert
Review Comment:
I prefer group v2commands in set or enum , but not to introduce new method
for handling them. Stay in one method is good enough for now.
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/PrivilegesBuilder.scala:
##########
@@ -411,6 +469,26 @@ object PrivilegesBuilder {
outputObjs += tablePrivileges(table, actionType = actionType)
buildQuery(getQuery, inputObjs)
+ case "AppendData" => // DsV2 insert
Review Comment:
I prefer groupping v2commands in set or enum , but not to introduce new
method for handling them. Stay in one method is good enough for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
