bowenliang123 commented on code in PR #3838:
URL: https://github.com/apache/incubator-kyuubi/pull/3838#discussion_r1032057950
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/SparkOperation.scala:
##########
@@ -73,11 +76,24 @@ abstract class SparkOperation(session: Session)
spark.conf.getOption(KyuubiConf.OPERATION_SCHEDULER_POOL.key).orElse(
session.sessionManager.getConf.get(KyuubiConf.OPERATION_SCHEDULER_POOL))
+ protected val isSessionUserVerifyEnabled: Boolean =
spark.sparkContext.getConf.getBoolean(
+ s"spark.${SESSION_USER_VERIFY_ENABLED.key}",
+ SESSION_USER_VERIFY_ENABLED.defaultVal.get)
+
protected def withLocalProperties[T](f: => T): T = {
try {
spark.sparkContext.setJobGroup(statementId, redactedStatement,
forceCancel)
spark.sparkContext.setLocalProperty(KYUUBI_SESSION_USER_KEY,
session.user)
spark.sparkContext.setLocalProperty(KYUUBI_STATEMENT_ID_KEY, statementId)
+
+ if (isSessionUserVerifyEnabled) {
+ val (publicKey, privateKey) = SignUtils.generateKeyPair
+ val signed = SignUtils.signWithECDSA(session.user, privateKey)
+ val publicKeyStr =
Base64.getEncoder.encodeToString(publicKey.getEncoded)
+ spark.sparkContext.setLocalProperty(KYUUBI_SESSION_USER_PUBIC_KEY,
publicKeyStr)
+ spark.sparkContext.setLocalProperty(KYUUBI_SESSION_USER_SIGN, signed)
Review Comment:
It's alright to leave these local properties set, as they are generated and
refreshed in every statement execution.
But it's okay to clear them as well. Changes updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
