pan3793 commented on PR #3838: URL: https://github.com/apache/incubator-kyuubi/pull/3838#issuecomment-1328225327
Overall this LGTM, could you please add test cases on server side? I think it should include - positive case - sign enabled can not disable by session configuration - unmatched user and sign - sign enabled but no sign in configuration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
