packyan commented on code in PR #4168: URL: https://github.com/apache/kyuubi/pull/4168#discussion_r1091900117
########## extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/gen/JsonSpecFileGenerator.scala: ########## @@ -35,6 +35,7 @@ object JsonSpecFileGenerator { writeCommandSpecJson("table", TableCommands.data ++ IcebergCommands.data) writeCommandSpecJson("function", FunctionCommands.data) writeCommandSpecJson("scan", Scans.data) + writeCommandSpecJson("function_resource", Functions.data) Review Comment: > "function_resource" for a type of resource name could be confused, especially with "function". Any better suggestion for this? To obtain, we can divide resources into two types, command and entity, and generate two kinds of json files like function_command and function_entity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org