bowenliang123 commented on code in PR #4228:
URL: https://github.com/apache/kyuubi/pull/4228#discussion_r1094123945
##########
kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/HttpClientFactory.java:
##########
@@ -35,23 +42,35 @@ public class HttpClientFactory {
public static CloseableHttpClient createHttpClient(RestClientConf conf) {
RequestConfig requestConfig =
RequestConfig.custom()
- .setSocketTimeout(conf.getSocketTimeout())
- .setConnectTimeout(conf.getConnectTimeout())
Review Comment:
note: `setConnectTimeout` is removed in `httpclient5`, and changed to use
ConnectionConfig to set connect timeout.
```
ConnectionConfig.custom()
.setConnectTimeout(conf.getConnectTimeout(),
TimeUnit.MILLISECONDS)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
