zwangsheng commented on code in PR #4228:
URL: https://github.com/apache/kyuubi/pull/4228#discussion_r1118600879
##########
pom.xml:
##########
@@ -153,8 +153,10 @@
<hive.archive.name>apache-hive-${hive.engine.hive.version}-bin.tar.gz</hive.archive.name>
<hive.archive.mirror>${apache.archive.dist}/hive/hive-${hive.engine.hive.version}</hive.archive.mirror>
<hive.archive.download.skip>false</hive.archive.download.skip>
+ <httpcore.version>4.4.15</httpcore.version>
<httpclient.version>4.5.14</httpclient.version>
Review Comment:
Since it is not used, we should delete `httpclient.version`.
##########
pom.xml:
##########
@@ -153,8 +153,10 @@
<hive.archive.name>apache-hive-${hive.engine.hive.version}-bin.tar.gz</hive.archive.name>
<hive.archive.mirror>${apache.archive.dist}/hive/hive-${hive.engine.hive.version}</hive.archive.mirror>
<hive.archive.download.skip>false</hive.archive.download.skip>
+ <httpcore.version>4.4.15</httpcore.version>
<httpclient.version>4.5.14</httpclient.version>
Review Comment:
Why do we reuse 4.4.15 for http core , based on the fact that we already use
4.4.16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
