Yikf commented on code in PR #4241:
URL: https://github.com/apache/kyuubi/pull/4241#discussion_r1095806895
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -247,7 +250,7 @@ class KyuubiSessionImpl(
try {
if (_client != null) _client.closeSession()
} finally {
- if (engine != null) engine.close()
+ openSessionError.foreach { _ => if (engine != null) engine.close() }
Review Comment:
The egine will not be reused if the sharelevel is a CONNECTION and the
session is closed, so should close engine whether open session fails or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
