ulysses-you commented on code in PR #4241:
URL: https://github.com/apache/kyuubi/pull/4241#discussion_r1096868633
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -247,7 +250,7 @@ class KyuubiSessionImpl(
try {
if (_client != null) _client.closeSession()
} finally {
- if (engine != null) engine.close()
+ openSessionError.foreach { _ => if (engine != null) engine.close() }
Review Comment:
With connection share level, engine should close gracefully by itself.
Engine exit code will not be 0 if we close engine by Kyuubi Server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
