cfmcgrady commented on code in PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#discussion_r1099992975


##########
.github/workflows/master.yml:
##########
@@ -347,15 +349,16 @@ jobs:
           file: build/Dockerfile
           load: true
           tags: apache/kyuubi:latest
-      # from 
https://github.com/marketplace/actions/setup-minikube-kubernetes-cluster
       - name: Setup Minikube
-        uses: manusa/[email protected]
-        with:
-          minikube version: 'v1.28.0'
-          kubernetes version: 'v1.25.4'
-          github token: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          # https://minikube.sigs.k8s.io/docs/start/
+          curl -LO 
https://github.com/kubernetes/minikube/releases/download/${MINIKUBE_VERSION}/minikube-linux-amd64
+          sudo install minikube-linux-amd64 /usr/local/bin/minikube
+          minikube start --cpus 2 --memory 4096 
--kubernetes-version=${KUBERNETES_VERSION} --force
+          minikube image load apache/kyuubi:latest

Review Comment:
   add a comment to explain why we need to load the local docker image.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to