bowenliang123 commented on code in PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#discussion_r1100845860
##########
.github/workflows/master.yml:
##########
@@ -394,15 +398,12 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
- # from
https://github.com/marketplace/actions/setup-minikube-kubernetes-cluster
- name: Setup Minikube
- uses: manusa/[email protected]
- with:
- minikube version: 'v1.28.0'
- kubernetes version: 'v1.25.4'
- github token: ${{ secrets.GITHUB_TOKEN }}
- driver: docker
- start args: '--extra-config=kubeadm.ignore-preflight-errors=NumCPU
--force --cpus 2 --memory 4096'
+ run: |
+ # https://minikube.sigs.k8s.io/docs/start/
+ curl -LO
https://github.com/kubernetes/minikube/releases/download/${MINIKUBE_VERSION}/minikube-linux-amd64
Review Comment:
Cache the minikube in a followup PR to avoid file downloading in every build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
