ulysses-you commented on code in PR #4417:
URL: https://github.com/apache/kyuubi/pull/4417#discussion_r1118231466
##########
kyuubi-server/src/main/antlr4/org/apache/kyuubi/sql/KyuubiTrinoFeBaseParser.g4:
##########
@@ -54,9 +54,19 @@ statement
CAST LEFT_PAREN NULL AS SMALLINT RIGHT_PAREN KEY_SEQ COMMA
CAST LEFT_PAREN NULL AS VARCHAR RIGHT_PAREN PK_NAME
WHERE FALSE
#getPrimaryKeys
+ | EXECUTE IDENTIFIER (USING parameterList)?
#getPrepareParameters
+ | PREPARE IDENTIFIER FROM statement
#getPrepareSql
Review Comment:
let's follow the Trino style:
`getPrepareParameters` -> `execute`
`getPrepareSql` -> `prepare`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
