ulysses-you commented on code in PR #4417:
URL: https://github.com/apache/kyuubi/pull/4417#discussion_r1128877168
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/trino/api/TrinoContext.scala:
##########
@@ -187,13 +187,20 @@ object TrinoContext {
queryHtmlUri: URI,
queryStatus: OperationStatus,
columns: Option[TGetResultSetMetadataResp] = None,
- data: Option[TRowSet] = None): QueryResults = {
+ data: Option[TRowSet] = None,
+ updateType: String = null): QueryResults = {
Review Comment:
how about pass a functon how to convert row se to list ?
`convertRowListFunc: => List[List[Object]]`
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/trino/api/TrinoContext.scala:
##########
@@ -187,13 +187,20 @@ object TrinoContext {
queryHtmlUri: URI,
queryStatus: OperationStatus,
columns: Option[TGetResultSetMetadataResp] = None,
- data: Option[TRowSet] = None): QueryResults = {
+ data: Option[TRowSet] = None,
+ updateType: String = null): QueryResults = {
Review Comment:
how about pass a functon how to convert row set to list ?
`convertRowListFunc: => List[List[Object]]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
