dev-lpq commented on code in PR #4690:
URL: https://github.com/apache/kyuubi/pull/4690#discussion_r1163644176
##########
charts/kyuubi/templates/kyuubi-rbac.yaml:
##########
@@ -17,15 +17,19 @@
{{- if .Values.rbac.create }}
apiVersion: rbac.authorization.k8s.io/v1
+kind: Role
+metadata:
+ name: {{ .Release.Name }}
+ labels:
+ {{- include "kyuubi.labels" . | nindent 4 }}
+rules: {{- toYaml .Values.rbac.rules | nindent 2 }}
+---
+apiVersion: rbac.authorization.k8s.io/v1
Review Comment:
@dnskr. Of course, it is the correct way each resource definition should be
in its own template file. I think roles and role-binding belong to Role-based
Access Control service. And the meaning is more concise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
