dev-lpq commented on code in PR #4690: URL: https://github.com/apache/kyuubi/pull/4690#discussion_r1163642480
########## charts/kyuubi/templates/_helpers.tpl: ########## @@ -31,3 +31,21 @@ For details, see 'kyuubi.frontend.protocols': https://kyuubi.readthedocs.io/en/m {{- end }} {{- $protocols | join "," }} {{- end }} + +{{/* +Generate kyuubi common labels. +*/}} +{{- define "kyuubi.common.labels" -}} +app.kubernetes.io/name: {{ .Chart.Name }} +app.kubernetes.io/instance: {{ .Release.Name }} +{{- end -}} + +{{/* +Generate kyuubi labels. +*/}} +{{- define "kyuubi.labels" -}} +{{ include "kyuubi.common.labels" . }} +helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version }} +app.kubernetes.io/version: {{ .Values.image.tag | default .Chart.AppVersion | quote }} +app.kubernetes.io/managed-by: {{ .Release.Service }} +{{- end -}} Review Comment: Label info is relatively fixed and is frequently used in templates, reducing code redundancy. Define common tags that make yaml cleaner and easy to read. I think this change is needed. new PR https://github.com/apache/kyuubi/pull/4698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
