bowenliang123 commented on code in PR #4733:
URL: https://github.com/apache/kyuubi/pull/4733#discussion_r1184990144
##########
kyuubi-events/src/main/scala/org/apache/kyuubi/events/EventLoggerType.scala:
##########
@@ -22,5 +22,5 @@ object EventLoggerType extends Enumeration {
type EventLoggerType = Value
// TODO: Only SPARK is done now
- val SPARK, JSON, JDBC, CUSTOM = Value
+ val SPARK, JSON, JDBC, KAFKA, CUSTOM = Value
Review Comment:
`KAFKA` value is added before `CUSTOM` here, in order to
1. follow the same order as in docs
2. `CUSTOM` is an extra option, which could be listed behind the options
with embedded support
I'm open to your suggestion. WDYT @pan3793 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
