pan3793 commented on code in PR #4733:
URL: https://github.com/apache/kyuubi/pull/4733#discussion_r1187098669
##########
kyuubi-server/pom.xml:
##########
@@ -486,6 +503,27 @@
<artifactId>flexmark-all</artifactId>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.kafka</groupId>
+ <artifactId>kafka_${scala.binary.version}</artifactId>
Review Comment:
I think we are using Testcontainers for integration testing, why should we
depend on the Kafka server?
And after second thought, I prefer to use `MockProducer` rather than launch
a real Kafka broker, but the latter is also fine for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
