pan3793 commented on code in PR #4849:
URL: https://github.com/apache/kyuubi/pull/4849#discussion_r1196247190


##########
kyuubi-common/src/test/scala/org/apache/kyuubi/util/SignUtilsSuite.scala:
##########
@@ -22,7 +22,7 @@ import java.util.Base64
 import org.apache.kyuubi.KyuubiFunSuite
 
 class SignUtilsSuite extends KyuubiFunSuite {
-  test("generate key pair") {
+  ignore("generate key pair") {

Review Comment:
   Failed on JDK 17
   ```
   SignUtilsSuite:
   - generate key pair *** FAILED ***
     java.security.InvalidAlgorithmParameterException: Curve not supported: 
secp256k1 (1.3.132.0.10)
     at 
jdk.crypto.ec/sun.security.ec.ECKeyPairGenerator.ensureCurveIsSupported(ECKeyPairGenerator.java:136)
     at 
jdk.crypto.ec/sun.security.ec.ECKeyPairGenerator.initialize(ECKeyPairGenerator.java:114)
     at 
java.base/java.security.KeyPairGenerator$Delegate.initialize(KeyPairGenerator.java:698)
     at 
org.apache.kyuubi.util.SignUtils$.ecKeyPairGenerator$lzycompute(SignUtils.scala:30)
     at org.apache.kyuubi.util.SignUtils$.ecKeyPairGenerator(SignUtils.scala:28)
     at org.apache.kyuubi.util.SignUtils$.generateKeyPair(SignUtils.scala:37)
     at 
org.apache.kyuubi.util.SignUtilsSuite.$anonfun$new$1(SignUtilsSuite.scala:26)
     at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
     at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
     at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
     ...
   - sign/verify with key pair *** FAILED ***
     java.security.InvalidAlgorithmParameterException: Curve not supported: 
secp256k1 (1.3.132.0.10)
     at 
jdk.crypto.ec/sun.security.ec.ECKeyPairGenerator.ensureCurveIsSupported(ECKeyPairGenerator.java:136)
     at 
jdk.crypto.ec/sun.security.ec.ECKeyPairGenerator.initialize(ECKeyPairGenerator.java:114)
     at 
java.base/java.security.KeyPairGenerator$Delegate.initialize(KeyPairGenerator.java:698)
     at 
org.apache.kyuubi.util.SignUtils$.ecKeyPairGenerator$lzycompute(SignUtils.scala:30)
     at org.apache.kyuubi.util.SignUtils$.ecKeyPairGenerator(SignUtils.scala:28)
     at org.apache.kyuubi.util.SignUtils$.generateKeyPair(SignUtils.scala:37)
     at 
org.apache.kyuubi.util.SignUtilsSuite.$anonfun$new$3(SignUtilsSuite.scala:36)
     at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
     at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
     at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
     ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to