bowenliang123 commented on code in PR #4849:
URL: https://github.com/apache/kyuubi/pull/4849#discussion_r1196582100


##########
kyuubi-common/src/test/scala/org/apache/kyuubi/util/SignUtilsSuite.scala:
##########
@@ -22,7 +22,7 @@ import java.util.Base64
 import org.apache.kyuubi.KyuubiFunSuite
 
 class SignUtilsSuite extends KyuubiFunSuite {
-  test("generate key pair") {
+  ignore("generate key pair") {

Review Comment:
   Maybe we could try the other curve spec "secp384r1" to see whether it pass 
on java 8\11\17 (mentioned on 
https://www.oracle.com/java/technologies/javase/8all-relnotes.html).
   I have found the supported cure spec list on Javadocs. Although it did say 
RSA is supported on any version of Java, I would still prefer elliptic curve 
(EC) mechanism for much smaller size of  key and encrypted message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to