pan3793 commented on code in PR #4887:
URL: https://github.com/apache/kyuubi/pull/4887#discussion_r1206488162
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EngineTab.scala:
##########
@@ -110,7 +110,7 @@ case class EngineTab(
// but if use sbt to build for testing, e.g. docker image, it still uses
vanilla jetty classes.
val shaded = "org.sparkproject.jetty.servlet.ServletContextHandler"
val vanilla = "org.eclipse.jetty.servlet.ServletContextHandler"
- if (ClassUtils.classIsLoadable(shaded)) {
+ if (ReflectUtils.isClassLoadable(shaded)) {
Review Comment:
it's not enough, let's do it in this one.
- use the chained builder
- inline the code and remove method `loadSparkServletContextHandler`
- rewrite the code behind invoking of `loadSparkServletContextHandler`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
