pan3793 commented on code in PR #4887:
URL: https://github.com/apache/kyuubi/pull/4887#discussion_r1206507426
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EngineTab.scala:
##########
@@ -62,8 +62,13 @@ case class EngineTab(
sparkUI.foreach { ui =>
try {
- // Spark shade the jetty package so here we use reflection
- val sparkServletContextHandlerClz = loadSparkServletContextHandler
+ // [KYUUBI #3627]: the official spark release uses the shaded and
relocated jetty classes,
+ // but if use sbt to build for testing, e.g. docker image, it still uses
+ // vanilla jetty classes.
Review Comment:
```suggestion
// [KYUUBI #3627]: the official spark release uses the shaded and
relocated jetty classes,
// but if we use sbt to build for testing, e.g. docker image, it still
uses the vanilla
// jetty classes.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
