rhh777 commented on PR #4886: URL: https://github.com/apache/kyuubi/pull/4886#issuecomment-1568341613
> The implementation looks good to me, but I don't think the code should be put into `KyuubiJdbcUtils`, the code is not reusable totally, and it is compose of specific logic, not generic enough to put into a `*Utils`. > > I would suggest move the `initializeJdbcSession` into `JdbcSQLEngine` directly. But if you consist, I'm fine to merge it as-is. Do you mean that `KyuubiJdbcUtils` methods are all move to `JdbcSQLEngine`? `JdbcSessionImpl open()` calls the `initializeJdbcSession` method of `JdbcSQLEngine`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
