rhh777 commented on PR #4886: URL: https://github.com/apache/kyuubi/pull/4886#issuecomment-1569463208
> Yes, all things in `KyuubiJdbcUtils`. And the second method can be inlined, I don't see the benefit of extracting it as a method. After `JdbcSQLEngine` is initialized, the connection can be closed. However, after `JdbcSessionImpl open()` is initialized, the connection cannot be closed and will be used by the sql of subsequent users. So the `initializeJdbcSession` method is split. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
