pan3793 commented on code in PR #4984:
URL: https://github.com/apache/kyuubi/pull/4984#discussion_r1237302897
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/api/Metadata.scala:
##########
@@ -66,6 +68,8 @@ case class Metadata(
createTime: Long = 0L,
engineType: String = null,
clusterManager: Option[String] = None,
+ kubernetesContext: Option[String] = None,
+ kubernetesNamespace: Option[String] = None,
Review Comment:
will this cause metadata DDL change? I prefer to store them in requestConf,
and make them as method instead of `val`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
