pan3793 commented on code in PR #4984:
URL: https://github.com/apache/kyuubi/pull/4984#discussion_r1241709678
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1106,13 +1132,31 @@ object KyuubiConf {
.stringConf
.createOptional
+ val KUBERNETES_CONTEXT_LIST: ConfigEntry[Seq[String]] =
+ buildConf("kyuubi.kubernetes.context.list")
Review Comment:
```suggestion
buildConf("kyuubi.kubernetes.context.allow.list")
```
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1106,13 +1132,31 @@ object KyuubiConf {
.stringConf
.createOptional
+ val KUBERNETES_CONTEXT_LIST: ConfigEntry[Seq[String]] =
+ buildConf("kyuubi.kubernetes.context.list")
+ .doc("The supported kubernetes context list, if it is empty," +
+ " there is no kubernetes context limitation.")
+ .version("1.8.0")
+ .stringConf
+ .toSequence()
+ .createWithDefault(Nil)
+
val KUBERNETES_NAMESPACE: ConfigEntry[String] =
buildConf("kyuubi.kubernetes.namespace")
.doc("The namespace that will be used for running the kyuubi pods and
find engines.")
.version("1.7.0")
.stringConf
.createWithDefault("default")
+ val KUBERNETES_NAMESPACE_LIST: ConfigEntry[Seq[String]] =
+ buildConf("kyuubi.kubernetes.namespace.list")
Review Comment:
```suggestion
buildConf("kyuubi.kubernetes.namespace.allow.list")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
