pan3793 commented on code in PR #5015:
URL: https://github.com/apache/kyuubi/pull/5015#discussion_r1252606712


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -507,6 +507,15 @@ object KyuubiConf {
       .serverOnly
       .fallbackConf(FRONTEND_BIND_PORT)
 
+  val FRONTEND_THRIFT_CONNECTION_URL_HOST: ConfigEntry[String] =
+    buildConf("kyuubi.frontend.thrift.connection.url.host")

Review Comment:
   The following configuration is used by Apache Kafka
   
   ```
   advertised.host.name
   advertised.port
   advertised.listeners
   ```
   
   I would call it `kyuubi.frontend.thrift.advertised.host`, if you want, we 
call it `kyuubi.frontend.advertised.host` and apply it to all frontends.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to