touchida commented on code in PR #5015:
URL: https://github.com/apache/kyuubi/pull/5015#discussion_r1257706847
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -507,6 +507,15 @@ object KyuubiConf {
.serverOnly
.fallbackConf(FRONTEND_BIND_PORT)
+ val FRONTEND_THRIFT_CONNECTION_URL_HOST: ConfigEntry[String] =
+ buildConf("kyuubi.frontend.thrift.connection.url.host")
Review Comment:
Thanks for your advice!
`advertised.host` sounds better to me.
Fixed at 34c61d9.
I also applied the configuration property to all frontends.
But I did not introduce separate properties for each frontend at this time.
It's possible, but I think such a use case is rare.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
