pan3793 commented on code in PR #5058: URL: https://github.com/apache/kyuubi/pull/5058#discussion_r1264990565
########## charts/kyuubi/values.yaml: ########## @@ -36,6 +36,16 @@ serviceAccount: # Specifies ServiceAccount name to be used (created if `create: true`) name: ~ +# priorityClass used for Kyuubi server pod +priorityClass: + # Specifies whether a priorityClass should be created + create: false + # Specifies priorityClass name to be used (created if `create: true`) + name: ~ + # half of system-cluster-critical by default + value: 1000000000 + description: "This priority class should be used for kyuubi server pods only." Review Comment: I think the content should be the comment instead of the description. A meaningful description should explain the functionality/requirements of the object itself so that the K8s administers/operators know why the object should exist when they describe the object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
