camper42 commented on code in PR #5058:
URL: https://github.com/apache/kyuubi/pull/5058#discussion_r1265005543
##########
charts/kyuubi/values.yaml:
##########
@@ -36,6 +36,16 @@ serviceAccount:
# Specifies ServiceAccount name to be used (created if `create: true`)
name: ~
+# priorityClass used for Kyuubi server pod
+priorityClass:
+ # Specifies whether a priorityClass should be created
+ create: false
+ # Specifies priorityClass name to be used (created if `create: true`)
+ name: ~
+ # half of system-cluster-critical by default
+ value: 1000000000
+ description: "This priority class should be used for kyuubi server pods
only."
Review Comment:
helm generate PriorityClass like below
as it used by helm automaticially and has label describe it's managed by
Helm, maybe just delete the `description` field and leave comments only?
```
# Source: kyuubi/templates/kyuubi-priorityclass.yaml
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
name: my-cluster-critical
labels:
helm.sh/chart: kyuubi-0.1.0
app.kubernetes.io/name: kyuubi
app.kubernetes.io/instance: release-name
app.kubernetes.io/version: "1.7.1"
app.kubernetes.io/managed-by: Helm
value: 1e+09
description: This priority class should be used for kyuubi server pods only.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
