pan3793 commented on code in PR #5066:
URL: https://github.com/apache/kyuubi/pull/5066#discussion_r1267747642
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1503,6 +1503,14 @@ object KyuubiConf {
.checkValue(_ > 0, "the maximum must be positive integer.")
.createWithDefault(10)
+ val SESSION_ENGINE_DESTROY_TIMEOUT: ConfigEntry[Long] =
+ buildConf("kyuubi.session.engine.destroy.timeout")
Review Comment:
"startup" should be mentioned, otherwise the name is misleading, destroy
engine sounds too dangerous
```suggestion
buildConf("kyuubi.session.engine.startup.destroy.timeout")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
