pan3793 commented on code in PR #5066:
URL: https://github.com/apache/kyuubi/pull/5066#discussion_r1267766494
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1503,6 +1503,14 @@ object KyuubiConf {
.checkValue(_ > 0, "the maximum must be positive integer.")
.createWithDefault(10)
+ val SESSION_ENGINE_DESTROY_TIMEOUT: ConfigEntry[Long] =
+ buildConf("kyuubi.session.engine.destroy.timeout")
+ .doc("Timeout(ms) for the engine destroy,if engine destroy times out," +
+ "force destroy instead.")
Review Comment:
Suggest move the definition after
`buildConf("kyuubi.session.engine.startup.waitCompletion")`
```suggestion
.doc("Destroy engine startup process wait time, if the process does
not " +
"stop after this time, force destroy instead. This configuration
only " +
s"takes effect when
`${SESSION_ENGINE_STARTUP_WAIT_COMPLETION.key}=false`.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
