pan3793 commented on code in PR #5066:
URL: https://github.com/apache/kyuubi/pull/5066#discussion_r1267887328
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala:
##########
@@ -257,7 +261,10 @@ trait ProcBuilder {
logCaptureThread = null
}
if (destroyProcess && process != null) {
- process.destroyForcibly()
+ process.destroy()
+ if (!process.waitFor(engineStartupDestroyTimeout,
TimeUnit.MICROSECONDS)) {
+ process.destroyForcibly()
Review Comment:
we'd better add a log here to warn that we are going to forcibly kill
process `pid` due to the process does not exit after xxx s.
There is a tricky in getting pid from `Process` in Java8, but is easy since
9, we may need to introduce a method in `ProcessUtils`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
