pan3793 commented on code in PR #5066:
URL: https://github.com/apache/kyuubi/pull/5066#discussion_r1269105396
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala:
##########
@@ -262,7 +262,10 @@ trait ProcBuilder {
}
if (destroyProcess && process != null) {
process.destroy()
- if (!process.waitFor(engineStartupDestroyTimeout,
TimeUnit.MICROSECONDS)) {
+ if (!process.waitFor(engineStartupDestroyTimeout,
TimeUnit.MILLISECONDS)) {
+ warn(
+ "Engine startUp process destroy timeout, will be forced destroy
engine startUp process," +
+ "temp files generated by the process may not be cleaned up! ")
Review Comment:
```suggestion
warn("Engine startup process does not exit after " +
s"$engineStartupDestroyTimeout" ms, try to forcibly kill. " +
"Staging files generated by the process may be retained!")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
