dnskr commented on code in PR #5132:
URL: https://github.com/apache/kyuubi/pull/5132#discussion_r1285199542
##########
charts/kyuubi/templates/kyuubi-podmonitor.yaml:
##########
@@ -0,0 +1,31 @@
+{{/*
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/}}
+
+{{- if and .Values.server.prometheus.enabled (eq .Values.metricsReporters
"PROMETHEUS") .Values.podMonitor.enabled }}
Review Comment:
Am I right that Prometheus Operator and related CRDs are required to be
installed for `PrometheusRule`, `PodMonitor` and `ServiceMonitor` to be used?
If so, it makes sense and is enough to just disable resource creation by
default instead of making API check, i.e. set the following default values and
revert API checks:
```yaml
podMonitor:
enabled: false
...
serviceMonitor:
enabled: false
...
prometheusRule:
enabled: false
...
```
It is more preferable behavior to create the resource if `enabled=true`,
even if the resource cannot be used in the Kubernetes cluster. For example, a
user can deploy Kyuubi helm chart with enabled `ServiceMonitor` (ServiceMonitor
resource will be created) to the cluster without Prometheus Operator, add
Prometheus Operator later and everything will work as expected. In the current
implementation with API checks a user will need to run `helm upgrade` command
explicitly to trigger ServiceMonitor resource creation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
