dev-lpq commented on code in PR #5132:
URL: https://github.com/apache/kyuubi/pull/5132#discussion_r1285327713
##########
charts/kyuubi/templates/kyuubi-alert.yaml:
##########
@@ -0,0 +1,30 @@
+{{/*
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/}}
+
+{{- if and .Values.server.prometheus.enabled (eq .Values.metricsReporters
"PROMETHEUS") -}}
Review Comment:
I think this is needed, Prometheus monitoring is built under `(eq
.Values.metricsReporters "PROMETHEUS")`. And the port `10019` is the Prometheus
metrics HTTP server port. As mentioned in `Why are the changes needed?`,
Integrating Prometheus as the metrics collection method in the Kyuubi Helm
Chart simplifies the configuration and deployment process, provides a
standardized monitoring solution, and makes monitoring in the Kubernetes
cluster more convenient and reliable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
