zhuyaogai commented on code in PR #5182:
URL: https://github.com/apache/kyuubi/pull/5182#discussion_r1303119541
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/SessionLimiter.scala:
##########
@@ -101,14 +101,21 @@ class SessionLimiterImpl(userLimit: Int, ipAddressLimit:
Int, userIpAddressLimit
}
}
-class SessionLimiterWithUnlimitedUsersImpl(
+class SessionLimiterWithAccessControlListImpl(
userLimit: Int,
ipAddressLimit: Int,
userIpAddressLimit: Int,
- var unlimitedUsers: Set[String])
+ var unlimitedUsers: Set[String],
+ var limitedUsers: Set[String])
extends SessionLimiterImpl(userLimit, ipAddressLimit, userIpAddressLimit) {
override def increment(userIpAddress: UserIpAddress): Unit = {
- if (!unlimitedUsers.contains(userIpAddress.user)) {
+ val user = userIpAddress.user
+ if (StringUtils.isNotBlank(user) && limitedUsers.contains(user)) {
Review Comment:
@pan3793 hi, I am new to kyuubi, could you give me more details about the
meaning of `limited user` or more guidance? From the issue context I cannot
get more input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
