zhuyaogai commented on code in PR #5182:
URL: https://github.com/apache/kyuubi/pull/5182#discussion_r1304511989
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/SessionLimiter.scala:
##########
@@ -101,14 +101,21 @@ class SessionLimiterImpl(userLimit: Int, ipAddressLimit:
Int, userIpAddressLimit
}
}
-class SessionLimiterWithUnlimitedUsersImpl(
+class SessionLimiterWithAccessControlListImpl(
userLimit: Int,
ipAddressLimit: Int,
userIpAddressLimit: Int,
- var unlimitedUsers: Set[String])
+ var unlimitedUsers: Set[String],
+ var limitedUsers: Set[String])
extends SessionLimiterImpl(userLimit, ipAddressLimit, userIpAddressLimit) {
override def increment(userIpAddress: UserIpAddress): Unit = {
- if (!unlimitedUsers.contains(userIpAddress.user)) {
+ val user = userIpAddress.user
+ if (StringUtils.isNotBlank(user) && limitedUsers.contains(user)) {
Review Comment:
Thank you very much for your guidance, but I also have some questions.
1. As you say `other users are not limited.`, so is the configuration
`kyuubi.server.limit.connections.user.unlimited.list` still needed?
2. If we limit connections for some users, do we need to do something
similar for `ipaddress` and `user-ipaddress`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
