pan3793 commented on code in PR #5344: URL: https://github.com/apache/kyuubi/pull/5344#discussion_r1340173062
##########
docs/configuration/settings.md:
##########
@@ -352,16 +352,16 @@ You can configure the Kyuubi properties in
`$KYUUBI_HOME/conf/kyuubi-defaults.co
### Metrics
-| Key | Default |
Meaning
| Type | Since |
-|---------------------------------|----------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|----------|-------|
-| kyuubi.metrics.console.interval | PT5S | How often should report metrics
to console
| duration | 1.2.0 |
-| kyuubi.metrics.enabled | true | Set to true to enable kyuubi
metrics system
| boolean | 1.2.0 |
-| kyuubi.metrics.json.interval | PT5S | How often should report metrics
to JSON file
| duration | 1.2.0 |
-| kyuubi.metrics.json.location | metrics | Where the JSON metrics file
located
| string | 1.2.0 |
-| kyuubi.metrics.prometheus.path | /metrics | URI context path of prometheus
metrics HTTP server
| string | 1.2.0 |
-| kyuubi.metrics.prometheus.port | 10019 | Prometheus metrics HTTP server
port
| int | 1.2.0 |
-| kyuubi.metrics.reporters | JSON | A comma-separated list for all
metrics reporters<ul> <li>CONSOLE - ConsoleReporter which outputs measurements
to CONSOLE periodically.</li> <li>JMX - JmxReporter which listens for new
metrics and exposes them as MBeans.</li> <li>JSON - JsonReporter which outputs
measurements to json file periodically.</li> <li>PROMETHEUS -
PrometheusReporter which exposes metrics in Prometheus format.</li> <li>SLF4J -
Slf4jReporter which outputs measurements to system log periodically.</li></ul>
| set | 1.2.0 |
-| kyuubi.metrics.slf4j.interval | PT5S | How often should report metrics
to SLF4J logger
| duration | 1.2.0 |
+| Key | Default |
Meaning
| Type | Since |
+|---------------------------------|------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|----------|-------|
+| kyuubi.metrics.console.interval | PT5S | How often should report
metrics to console
| duration | 1.2.0
|
+| kyuubi.metrics.enabled | true | Set to true to enable kyuubi
metrics system
| boolean | 1.2.0 |
+| kyuubi.metrics.json.interval | PT5S | How often should report
metrics to JSON file
| duration | 1.2.0
|
+| kyuubi.metrics.json.location | metrics | Where the JSON metrics file
located
| string | 1.2.0 |
+| kyuubi.metrics.prometheus.path | /metrics | URI context path of
prometheus metrics HTTP server
| string |
1.2.0 |
+| kyuubi.metrics.prometheus.port | 10019 | Prometheus metrics HTTP
server port
| int | 1.2.0
|
+| kyuubi.metrics.reporters | PROMETHEUS | A comma-separated list for
all metrics reporters<ul> <li>CONSOLE - ConsoleReporter which outputs
measurements to CONSOLE periodically.</li> <li>JMX - JmxReporter which listens
for new metrics and exposes them as MBeans.</li> <li>JSON - JsonReporter which
outputs measurements to json file periodically.</li> <li>PROMETHEUS -
PrometheusReporter which exposes metrics in Prometheus format.</li> <li>SLF4J -
Slf4jReporter which outputs measurements to system log periodically.</li></ul>
| set | 1.8.0 |
Review Comment:
the version seems incorrect, have you regenerated it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
