pan3793 commented on code in PR #5344:
URL: https://github.com/apache/kyuubi/pull/5344#discussion_r1349701925


##########
kyuubi-server/src/test/scala/org/apache/kyuubi/events/handler/ServerJsonLoggingEventHandlerSuite.scala:
##########
@@ -56,6 +57,7 @@ class ServerJsonLoggingEventHandlerSuite extends 
WithKyuubiServer with HiveJDBCT
       .set(KyuubiConf.SERVER_EVENT_JSON_LOG_PATH, serverLogRoot)
       .set(KyuubiConf.ENGINE_SPARK_EVENT_LOGGERS, Seq("JSON"))
       .set(KyuubiConf.ENGINE_EVENT_JSON_LOG_PATH, engineLogRoot)
+      .set(METRICS_PROMETHEUS_PORT, 0)

Review Comment:
   How about
   ```suggestion
         .set(KyuubiConf. METRICS_REPORTERS, Seq.empty)
   ```
   
   I suppose it could speed up the test a little too.



##########
kyuubi-server/src/test/scala/org/apache/kyuubi/events/handler/ServerJsonLoggingEventHandlerSuite.scala:
##########
@@ -56,6 +57,7 @@ class ServerJsonLoggingEventHandlerSuite extends 
WithKyuubiServer with HiveJDBCT
       .set(KyuubiConf.SERVER_EVENT_JSON_LOG_PATH, serverLogRoot)
       .set(KyuubiConf.ENGINE_SPARK_EVENT_LOGGERS, Seq("JSON"))
       .set(KyuubiConf.ENGINE_EVENT_JSON_LOG_PATH, engineLogRoot)
+      .set(METRICS_PROMETHEUS_PORT, 0)

Review Comment:
   How about
   ```suggestion
         .set(KyuubiConf.METRICS_REPORTERS, Seq.empty)
   ```
   
   I suppose it could speed up the test a little too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to