pan3793 commented on PR #5410: URL: https://github.com/apache/kyuubi/pull/5410#issuecomment-1759402838
@davidyuan1223 thanks for your contribution, it's not necessary to put everything with screenshots, for example, it's clear to the reviewer to check your unit test code via GitHub. And would mind filling in "Why are the changes needed?", generally, for most of the PR, it's clear for the reviewer to check the code to understand "what you changed", but not "why are the changes needed". In addition, we provided some contributor guidance in https://github.com/apache/kyuubi/issues/5357, please read and fix the code style issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
